Windows Compatibility Preparation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
December 2, 2020 16:39
2 tasks
asklar
reviewed
Dec 3, 2020
Comment on lines
+7
to
+11
| const OSPathSeparator = Platform.select({ | ||
| ios: "/", | ||
| android: "/", | ||
| windows: "\\", | ||
| }); |
There was a problem hiding this comment.
is it possible to use path? if so you can just use path.sep if you need access to the separator
There was a problem hiding this comment.
I don't think so as it's React-Native JS world and not node.js?
Comment on lines
+13
to
+20
| const resolvePath = (...paths: Array<string>) => { | ||
| if (Platform.OS === "windows") { | ||
| return paths | ||
| .join(OSPathSeparator) | ||
| .split(OSPathSeparator) | ||
| .filter((part) => part && part !== ".") | ||
| .join(OSPathSeparator); | ||
| } |
There was a problem hiding this comment.
if you're able to use path then I think this is the same as path.normalize with a trailing separator?
asklar
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
I've been using your fork for some time now and thought I may contribute something small back ;-).
I've made some small changes to the index.js to prepare for Windows paths compatibility.
I'll remove the changes to yarn.lock and package.json if you'd be fine with merging the index.js changes.
The RN-FS windows support PR should merged rather sooner than later and this would prepare the Library for it.
Have already tested on Android & Windows & iOS